Re: [PATCH v2 1/5] maintenance: simplify prefetch logic
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Apr 7, 2021, 23:23 UTC
- Message-ID
- <YG4+67oe39IRnUzb@google.com>
- In-Reply-To
- <5aa0cb06c3f2e31a51bb6747fa84de69c0c1212f.1617734870.git.gitgitgadget@gmail.com>
Overall, the series looks pretty solid to me - which is why I've got a handful of small nits to relay. :)
On Tue, Apr 06, 2021 at 06:47:46PM +0000, Derrick Stolee via GitGitGadget wrote:
> -static int fetch_remote(const char *remote, struct maintenance_run_opts *opts)
> +static int fetch_remote(struct remote *remote, void *cbdata)
> {
> + struct maintenance_run_opts *opts = cbdata;[snip]
> if (opts->quiet)
I worry about the lack of null-checking here.
- Emily