Re: [PATCH v2 5/5] maintenance: allow custom refspecs during prefetch

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 6, 2021, 19:45 UTC
Message-ID: <35fa99cf-ba24-f13e-0607-f9acce2905cf@gmail.com>
In-Reply-To: <20210406193637.x2xqkkyqbjabgzge@dhcp-10-154-113-61.vpn.oracle.com>

On 4/6/2021 3:36 PM, Tom Saeger wrote:

>
> Junio brought up the point about configs which 'fetch' have no dst
> https://lore.kernel.org/git/c06a198a-2043-27a2-cab3-3471190754cc@gmail.com/

Thank you for reminding me about this. It was on the other thread, and I forgot to go back to it as I was preparing this version.

Show 9 quoted lines

>     [remote "submaintainer1"]
>         url = ... repository of submaintainer #1 ...
>         fetch = master
>         tagopt = --no-tags
> 
> 
> This patch fixes segfault for config like above.
> You might have ideas on a cleaner way to do this.
> I did add `child_process_clear`.

I will also add a test to ensure this scenario does not regress. -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.