Re: [PATCH 5/5] maintenance: allow custom refspecs during prefetch

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 6, 2021, 11:15 UTC
Message-ID: <41a4b531-d315-9743-34cc-d9f86c335f7d@gmail.com>
In-Reply-To: <20210405171652.xp63czmtsswqor2m@brm-x62-17.us.oracle.com>

On 4/5/2021 1:16 PM, Tom Saeger wrote:

Show 6 quoted lines

> On Mon, Apr 05, 2021 at 01:04:15PM +0000, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <dstolee@microsoft.com>
>> +		strvec_push(&child.args, refspec_item_format(&replace));
> 
> see comment on 3/5, think refspec_item_format is leaking here.
> this code looks fine though.

I will respond to the comments on patch 3, but this is the reason a static strbuf is used: we can print like this without needing to store the buffer in a variable and free() it here. Seemed like an easier-to-use API for a non-critical area of code. I'll continue the discussion over on that patch thread.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.