Re: [PATCH v3 1/3] maintenance: simplify prefetch logic

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 12, 2021, 20:27 UTC
Message-ID: <2f4fa2b5-0d8b-b368-ab4d-411740595a4f@gmail.com>
In-Reply-To: <20210412201308.teugitvky5cctcio@dhcp-10-154-186-72.vpn.oracle.com>

On 4/12/21 4:13 PM, Tom Saeger wrote:

Show 18 quoted lines

> On Sat, Apr 10, 2021 at 02:03:43AM +0000, Derrick Stolee via GitGitGadget wrote:
>> -static int fetch_remote(const char *remote, struct maintenance_run_opts *opts)
>> +static int fetch_remote(struct remote *remote, void *cbdata)
>>  {
>> +	struct maintenance_run_opts *opts = cbdata;
>>  	struct child_process child = CHILD_PROCESS_INIT;
> 
> 
> I think this might be appropriate to add:
> 
> 
>        if (remote->skip_default_update)
>                return 0;
> 
> 
> maintenance prefetch is acting like `git fetch --all`
> So it should also skip remotes with configs `skipfetchall = true`
> Agree?

TIL about skipfetchall. I think that's a good idea to introduce. It'll be a new patch, not added in this one.

Thanks, -Stolee