Re: [PATCH v10 2/3] interpret-trailers: add own-identity option
- From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
- Date
- Mar 18, 2021, 16:45 UTC
- Message-ID
- <YFODnm4JKfqRn37H@danh.dev>
- In-Reply-To
- <42590e95deeece6ba65e0432c3a59746e717fee3.1616066156.git.gitgitgadget@gmail.com>
On 2021-03-18 11:15:55+0000, ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com> wrote:
> From: ZheNing Hu <adlternative@gmail.com> > > Beacuse `git commit --trailer="Signed-off-by: \
s/Beacuse/Because/
And I think, it's easier to read if we write the command in its own (indented) line.
Show 6 quoted lines
> $(git config user.name) <$(git config user.email)>"` > is difficult for users to add their own identities, > so teach interpret-trailers a new option `--own-identity` > which allow those trailers with no value add the user’s own > identity. This will help the use of `commit --trailer` as > easy as `--signoff`.
Perhap, saying that we're optionalise <value> in --trailer, by substitute user's identity if missing instead?
Show 5 quoted lines
> @@ -131,6 +144,7 @@ OPTIONS > when you know your input contains just the commit message itself > (and not an email or the output of `git format-patch`). > > +
I think it's better to not add this line change
Show 7 quoted lines
> CONFIGURATION VARIABLES > ----------------------- > > diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c > index 84748eafc01b..be7f502a58d7 100644 > --- a/builtin/interpret-trailers.c > +++ b/builtin/interpret-trailers.c
-- Danh