Re: [PATCH v7] [GSOC] commit: add --trailer option
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Mar 15, 2021, 10:14 UTC
- Message-ID
- <CAP8UFD2CNAW4o8BF8NLA0pwWzNmBwZJAP7L5SGSib+LcVbSLBA@mail.gmail.com>
- In-Reply-To
- <pull.901.v7.git.1615799304883.gitgitgadget@gmail.com>
On Mon, Mar 15, 2021 at 10:08 AM ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 6 quoted lines
> + if (trailer_args.nr) {
> -+ static struct child_process run_trailer = CHILD_PROCESS_INIT;
> ++ struct child_process run_trailer = CHILD_PROCESS_INIT;
> +
> + strvec_pushl(&run_trailer.args, "interpret-trailers",
> + "--in-place", "--where=end", git_path_commit_editmsg(), NULL);Actually I don't think "--where=end" should be used here. "end" is the default for the "trailer.where" config variable, so by default if nothing has been configured, it will work as if "--where=end" was passed above.
If a user has configured "trailer.where" or trailer.<token>.where, then this should be respected. And users should be able to override such config variable using for example:
git -c trailer.where=start commit --trailer "Signed-off-by:C O Mitter <committer@example.com>"