Re: [PATCH v10 0/3] [GSOC] commit: add --trailer option
Christian Couder <christian.couder@gmail.com> 于2021年3月18日周四 下午9:48写道：
Show 21 quoted lines
>
> On Thu, Mar 18, 2021 at 12:15 PM ZheNing Hu via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > Now maintainers or developers can also use commit
> > --trailer="Signed-off-by:commiter<email>" from the command line to provide
> > trailers to commit messages. This solution may be more generalized than v1.
> >
> > ZheNing Hu (3):
> > [GSOC] commit: add --trailer option
> > interpret-trailers: add own-identity option
> > commit: add own-identity option
>
> I see that you discussed an own-identity option in this thread
> recently, but this is version 10 of a patch series, so I don't think
> it's a good idea to introduce new features at this point. I think it's
> better to not tie the work that has already been done on polishing the
> first patch to new patches implementing an additional feature. The
> additional feature can be discussed and worked on in its own patch
> series building on top of this one.
>
OK, I understand that now. I will divide this patch series into two parts.
> Also it feels strange that only the first patch has "[GSOC]".
I forgot to add [GSOC]...
Thanks.
ZheNing Hu <adlternative@gmail.com>