Re: [PATCH v3 0/5] notes.c: introduce "--no-blank-line" option
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Nov 29, 2022, 22:53 UTC
- Message-ID
- <Y4aNbc1ZMxscyvU1@nand.local>
- In-Reply-To
- <xmqqzgca4lb7.fsf@gitster.g>
On Tue, Nov 29, 2022 at 10:10:52AM +0900, Junio C Hamano wrote:
Show 17 quoted lines
> Teng Long <dyroneteng@gmail.com> writes: > > >> Teng Long (5): > >> notes.c: cleanup 'strbuf_grow' call in 'append_edit' > >> notes.c: cleanup for "designated init" and "char ptr init" > >> notes.c: drop unreachable code in 'append_edit()' > >> notes.c: provide tips when target and append note are both empty > >> notes.c: introduce "--no-blank-line" option > > > > I'm not sure if this patch series should continue, and if there are no > > updated comments it will be temporarily suspended. > > > > Thanks for the reviews on the past patches. > > Taylor, This topic was marked to "expect" a reroll in the second > issue of November "What's cooking" report you did. Do you recall > what remaining works there were?
Looking at the dates, I sent that WC on 2022-11-08, which means that I most likely was referencing the discussion between the author and Ævar.
The following WC on 2022-11-14 likely should have changed the status to "Waiting for review".
Thanks, Taylor