Re: [PATCH v2 1/3] notes.c: introduce "--blank-line" option
On Mon, Nov 7, 2022 at 9:56 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 24 quoted lines
> On Mon, Nov 07 2022, Teng Long wrote:
> > When appending to a given object which has note and if the appended
> > note is not empty too, we will insert a blank line at first. The
> > blank line serves as a split line, but sometimes we just want to
> > omit it then append on the heels of the target note. So, we add
> > a new "OPT_BOOL()" option to determain whether a new blank line
> > is insert at first.
> >
> > Signed-off-by: Teng Long <dyroneteng@gmail.com>
> > ---
> > diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
> > @@ -159,6 +161,11 @@ OPTIONS
> > +--blank-line::
> > +--no-blank-line::
> > + Controls if a blank line to split paragraphs is inserted
> > + when appending (the default is true).
>
> Just make this:
>
> --no-blank-line:
> Suppress the insertion of a blank line before the
> inserted notes.
>
> Or something, i.e. when adding a "true by default" let's add a "no-..." variant directly.
This is the exact opposite of Junio's advice[1], isn't it?
[1]: https://lore.kernel.org/git/xmqqsfjsi7eq.fsf@gitster.g/