Re: [PATCH v2 2/3] notes.c: fixed tip when target and append note are both empty

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 7, 2022, 22:45 UTC
Message-ID: <Y2mKjwpRME3EnQGn@nand.local>
In-Reply-To: <221107.86bkpitmw6.gmgdl@evledraar.gmail.com>

On Mon, Nov 07, 2022 at 11:33:33PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> > I don't mind seeing the cleanup here, but I don't see why we need to
> > keep that portion of the hunk at all for this series.
> >
> > IOW, your "...and only need to keep this one" does not make sense to me.
>
> I was still on my initial read-through, and was assuming that it was a
> prep change for the 3/3 adding a new field, before I saw the 3/3...

Gotcha, makes sense. Thanks.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.