Re: [PATCH v2 2/3] notes.c: fixed tip when target and append note are both empty

From: Teng Long <dyroneteng@gmail.com>
Date: Nov 8, 2022, 08:55 UTC
Message-ID: <20221108085510.24275-1-tenglong.tl@alibaba-inc.com>
In-Reply-To: <221107.86bkpitmw6.gmgdl@evledraar.gmail.com>

"Ævar Arnfjörð Bjarmason" <avarab@gmail.com> writes:

>  I was still on my initial read-through, and was assuming that it was a
> prep change for the 3/3 adding a new field, before I saw the 3/3...

Yes, you are right, that previous patch add a "copy" of "d", but now it's unnecessary, so I think make a pre-cleanup commit which includes the "char *logmsg = NULL" and the "designated init" of "struct note_data d" looks nice.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.