Re: [PATCH v2 4/6] shortlog: support arbitrary commit format `--group`s
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 21, 2022, 22:07 UTC
- Message-ID
- <Y1MYBj5zcPza70/f@nand.local>
- In-Reply-To
- <Y1IyppKatD7piHOO@coredump.intra.peff.net>
On Fri, Oct 21, 2022 at 01:48:22AM -0400, Jeff King wrote:
Show 13 quoted lines
> > +test_expect_success 'shortlog multiple --group=format' ' > > + git shortlog -s --date="format:%Y" --group="format:%cN (%cd)" \ > > + HEAD >actual && > > + cat >expect <<-\EOF && > > + 4 C O Mitter (2005) > > + 1 Sin Nombre (2005) > > + EOF > > + test_cmp expect actual > > +' > > ...but this one seems redundant. It is not using multiple formats. And > you test that later, in the "can match multiple format groups" test. Is > this one just leftover from development?
Oops, yes. Thanks for catching it, I'll drop this one.
Show 6 quoted lines
> > +test_expect_success 'shortlog bogus --group' ' > > + test_must_fail git shortlog --group=bogus HEAD 2>err && > > + grep "unknown group type" err > > +' > > This one is a nice inclusion. I was surprised we didn't have it already. :)
:-).
Thanks, Taylor