Re: [PATCH 7/7] shortlog: implement `--group=trailer` in terms of `--group=<format>`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 21, 2022, 01:38 UTC
Message-ID: <Y1H4MeYXv06mjKg0@nand.local>
In-Reply-To: <Y0TL8unKev9TPytJ@coredump.intra.peff.net>

On Mon, Oct 10, 2022 at 09:50:42PM -0400, Jeff King wrote:

> Hmph. So that's _probably_ OK, but I have to wonder if this is going too
> far. The resulting code is not that much shorter, and IMHO is actually a
> little more complicated, because of this hack and the extra util bit.

Thanks for a careful analysis, as always. "Additional complexity" and "slower" are both usually not worth it in isolation, but it's definitely difficult to advocate for doing both at the same time ;-).

Let's drop this patch and let the `--group=trailer` bits continue to benefit from your optimizations.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.