Re: [PATCH v2 0/6] shortlog: introduce `--group=<format>`

From: Jeff King <peff@peff.net>
Date: Oct 21, 2022, 05:53 UTC
Message-ID: <Y1Izx2Gw4C7dJEex@coredump.intra.peff.net>
In-Reply-To: <cover.1666320509.git.me@ttaylorr.com>

On Thu, Oct 20, 2022 at 11:11:25PM -0400, Taylor Blau wrote:

Show 10 quoted lines

> Here is a reroll of my series to implement arbitrary pretty formats as
> shortlog `--group`'s, based on a suggestion from Jacob Stopak.
> 
> The changes are somewhat minimal, including a rebase onto the current
> tip of master. Less minimal, however, is dropping the reimplementation
> of `--group=trailer:<key>` in terms of the format group, since this
> ended up being more trouble than it was worth.
> 
> There are also a handful of small tweaks throughout based on feedback
> from Peff.

Thanks. This mostly looks good to me, though I think there are a few doc and test nits that make it worth one more reroll. I had various style and ordering suggestions, too. I'll leave it to you whether you think it's worth taking any of them during the re-roll, or just ignoring them. :)

-Peff