Re: [PATCH 4/7] shortlog: support arbitrary commit format `--group`s

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 11, 2022, 01:28 UTC
Message-ID: <Y0TGuFDhoG1Nu6ND@nand.local>
In-Reply-To: <Y0TF0M6UzLS9r6iM@nand.local>

On Mon, Oct 10, 2022 at 09:24:32PM -0400, Taylor Blau wrote:

Show 6 quoted lines

> > Makes sense. Two other tests that might be worth including:
> >
> >   - "shortlog --group=bogus" generates an error (we might already have
> >     such a test; I didn't check)
>
> We didn't have such a test before, so adding one is a good call, thanks!

Just writing back to say that this was a really good suggestion, since it caught my mistake in writing:

    } else if (strchrnul(arg, '%')) {

since we'll always get back a non-NULL answer from calling `strchrnul` instead of `strchr`.

Thanks ;-).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.