git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t3903-stash: improve testing of git-stash show

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Sep 24, 2010, 20:50 UTC
Message-ID
<UNSmPBO95_JSGKkZEyMl028XH9fmWCis39YCV_49wZs7FghyXRqw2Q@cipher.nrlssc.navy.mil>
In-Reply-To
<47BAA71F-CF5C-4A98-BBB9-C502C81E3230@silverinsanity.com>
On 09/24/2010 03:43 PM, Brian Gernhardt wrote:
Show 13 quoted lines
>> On 09/24/2010 03:27 PM, Brian Gernhardt wrote:
>>> I bisected the issue to a9bf09e (detached-stash: simplify git stash show),
>>> which is when "git stash show" started using parse_flags_and_rev (via
>>> assert_stash_like()).
>>>
>>> More worrying to me is that the tests for "git stash show" don't bother
>>> to test the output.  I'll be working on that now.
>>
>> I was preparing these tests when your email came in.
> 
> I spent longer finding the source of the problem than you did.  I was just
> putting the finishing touches on it when I got this.  Yours is more through
> than mine, so I won't bother finishing.

I hope you're just abandoning the tests you were creating, and _not_ abandoning the search for a fix. The "solution" I offered is flawed and breaks some of the other tests. :)

-Brandon
Previous: Brian GernhardtNext: Brian Gernhardt
Message 6 of 27 in “git-1.7.3 breakage: "git stash show xxx" doesn't show anything”
  1. Robin H. JohnsonSep 24, 2010
  2. Brandon CaseySep 24, 2010
  3. Brian GernhardtSep 24, 2010
  4. t/t3903-stash: improve testing of git-stash showBrandon Casey, Sep 24, 2010
  5. Brian GernhardtSep 24, 2010
  6. Brandon CaseySep 24, 2010
  7. Brian GernhardtSep 24, 2010
  8. git-stash: fix flag parsingBrian Gernhardt, Sep 24, 2010
  9. git-stash: fix flag parsingBrian Gernhardt, Sep 24, 2010
  10. Jon SeymourSep 25, 2010
  11. Junio C HamanoSep 27, 2010
  12. stash: simplify parsing fixesJon Seymour, Sep 27, 2010
  13. stash show: fix breakage in 1.7.3Jon Seymour, Sep 25, 2010
  14. stash show: fix breakage in 1.7.3Jon Seymour, Sep 25, 2010
  15. Brian GernhardtSep 25, 2010
  16. Jon SeymourSep 25, 2010
  17. Jon SeymourSep 25, 2010
  18. Jon SeymourSep 27, 2010
  19. rev-parse: stop interpreting flags as options to rev-parse once --flags is specifiedJon Seymour, Sep 25, 2010
  20. Jon SeymourSep 25, 2010
  21. Jon SeymourSep 25, 2010
  22. Junio C HamanoSep 26, 2010
  23. Jon SeymourSep 26, 2010
  24. 0/3 rev-parse: allow --flags to output rev-parse-like flagsJon Seymour, Sep 26, 2010
  25. 1/3 rev-parse: update Documentation of --flagsJon Seymour, Sep 26, 2010
  26. 2/3 rev-parse: add tests for git rev-parse --flags.Jon Seymour, Sep 26, 2010
  27. 3/3 rev-parse: stop interpreting flags as options to rev-parse once --flags is specifiedJon Seymour, Sep 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.