Re: git-1.7.3 breakage: "git stash show xxx" doesn't show anything

From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Sep 24, 2010, 20:27 UTC
Message-ID: <00400143-1A23-4245-9D7C-4AC9093785F5@gernhardtsoftware.com>
In-Reply-To: <iET3wn06TheqzndLNXxSuZJHDP5RwU5NWenjr2MQJI96tqWxE3MYjw@cipher.nrlssc.navy.mil>

On Sep 24, 2010, at 4:01 PM, Brandon Casey wrote:

Show 14 quoted lines

> Probably,
> 
> diff --git a/git-stash.sh b/git-stash.sh
> index 7ce818b..4fbfb62 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -265,7 +265,7 @@ parse_flags_and_rev()
>        i_tree=
> 
>        REV=$(git rev-parse --no-flags --symbolic "$@" 2>/dev/null)
> -       FLAGS=$(git rev-parse --no-revs -- "$@" 2>/dev/null)
> +       FLAGS=$(git rev-parse --no-revs --flags "$@" 2>/dev/null)
> 
>        set -- $FLAGS

I bisected the issue to a9bf09e (detached-stash: simplify git stash show), which is when "git stash show" started using parse_flags_and_rev (via assert_stash_like()).

More worrying to me is that the tests for "git stash show" don't bother to test the output.  I'll be working on that now.

~~ Brian