Re: [PATCH] t/t3903-stash: improve testing of git-stash show
On Sep 24, 2010, at 4:40 PM, Brandon Casey wrote:
Show 23 quoted lines
> From: Brandon Casey <drafnel@gmail.com>
>
> Recently, the 'stash show' functionality was broken for the case when a
> stash-like argument was supplied. Since, commit 9bf09e, 'stash show' when
> supplied a stash-like argument prints nothing and still exists with a zero
> status. Unfortunately, the flaw slipped through the test suite cracks
> since the output of 'stash show' was not verified to be correct.
>
> Improve and expand on the existing tests so that this flaws is detected.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>
>
> On 09/24/2010 03:27 PM, Brian Gernhardt wrote:
>> I bisected the issue to a9bf09e (detached-stash: simplify git stash show),
>> which is when "git stash show" started using parse_flags_and_rev (via
>> assert_stash_like()).
>>
>> More worrying to me is that the tests for "git stash show" don't bother
>> to test the output. I'll be working on that now.
>
> I was preparing these tests when your email came in.
I spent longer finding the source of the problem than you did. I was just putting the finishing touches on it when I got this. Yours is more through than mine, so I won't bother finishing.
~~ Brian
Brian Gernhardt <benji@silverinsanity.com>