From: Brandon Casey Date: Fri, 24 Sep 2010 20:50:19 GMT Subject: Re: [PATCH] t/t3903-stash: improve testing of git-stash show Message-ID: In-Reply-To: <47BAA71F-CF5C-4A98-BBB9-C502C81E3230@silverinsanity.com> On 09/24/2010 03:43 PM, Brian Gernhardt wrote: >> On 09/24/2010 03:27 PM, Brian Gernhardt wrote: >>> I bisected the issue to a9bf09e (detached-stash: simplify git stash show), >>> which is when "git stash show" started using parse_flags_and_rev (via >>> assert_stash_like()). >>> >>> More worrying to me is that the tests for "git stash show" don't bother >>> to test the output. I'll be working on that now. >> >> I was preparing these tests when your email came in. > > I spent longer finding the source of the problem than you did. I was just > putting the finishing touches on it when I got this. Yours is more through > than mine, so I won't bother finishing. I hope you're just abandoning the tests you were creating, and _not_ abandoning the search for a fix. The "solution" I offered is flawed and breaks some of the other tests. :) -Brandon