Re: [PATCH] Simplify crud() in ident.c
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 3, 2007, 22:48 UTC
- Message-ID
- <Pine.LNX.4.64.0712032247140.27959@racer.site>
- In-Reply-To
- <20071203213702.GD17671@steel.home>
Hi,
On Mon, 3 Dec 2007, Alex Riesen wrote:
Show 20 quoted lines
> Johannes Schindelin, Mon, Dec 03, 2007 21:47:09 +0100: > > On Mon, 3 Dec 2007, Alex Riesen wrote: > > > + return c <= 32 || > > > + c == '.' || > > > + c == ',' || > > > + c == ':' || > > > + c == ';' || > > > + c == '<' || > > > + c == '>' || > > > + c == '"' || > > > + c == '\''; > > > > Or enhance ctype.c. > > > > That's be nice, but the "crud" conflicts with existing classification, > so I'd have to change the is*-macros as well. Don't feel like it. > > I believe the code is never in hotpath anyway so the shorter the > better.
Really?
return !!strchr(".,:;<>\"\\", c);Ciao, Dscho