git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Simplify crud() in ident.c

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 3, 2007, 20:47 UTC
Message-ID
<Pine.LNX.4.64.0712032046480.27959@racer.site>
In-Reply-To
<20071203191143.GB17671@steel.home>
Hi,
On Mon, 3 Dec 2007, Alex Riesen wrote:
Show 36 quoted lines
> diff --git a/ident.c b/ident.c
> index 9b2a852..dbd0f52 100644
> --- a/ident.c
> +++ b/ident.c
> @@ -113,25 +113,15 @@ static int add_raw(char *buf, size_t size, int offset, const char *str)
>  
>  static int crud(unsigned char c)
>  {
> -	static char crud_array[256];
> -	static int crud_array_initialized = 0;
> -
> -	if (!crud_array_initialized) {
> -		int k;
> -
> -		for (k = 0; k <= 31; ++k) crud_array[k] = 1;
> -		crud_array[' '] = 1;
> -		crud_array['.'] = 1;
> -		crud_array[','] = 1;
> -		crud_array[':'] = 1;
> -		crud_array[';'] = 1;
> -		crud_array['<'] = 1;
> -		crud_array['>'] = 1;
> -		crud_array['"'] = 1;
> -		crud_array['\''] = 1;
> -		crud_array_initialized = 1;
> -	}
> -	return crud_array[c];
> +	return  c <= 32  ||
> +		c == '.' ||
> +		c == ',' ||
> +		c == ':' ||
> +		c == ';' ||
> +		c == '<' ||
> +		c == '>' ||
> +		c == '"' ||
> +		c == '\'';
Or enhance ctype.c.

Ciao, Dscho

Previous: Luke LuNext: Alex Riesen
Message 5 of 8 in “Simplify crud() in ident.c”
  1. Simplify crud() in ident.cAlex Riesen, Dec 3, 2007
  2. Jakub NarebskiDec 3, 2007
  3. Alex RiesenDec 3, 2007
  4. Luke LuDec 3, 2007
  5. Johannes SchindelinDec 3, 2007
  6. Alex RiesenDec 3, 2007
  7. Johannes SchindelinDec 3, 2007
  8. David KastrupDec 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.