Re: [PATCH] Simplify crud() in ident.c
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 3, 2007, 20:47 UTC
- Message-ID
- <Pine.LNX.4.64.0712032046480.27959@racer.site>
- In-Reply-To
- <20071203191143.GB17671@steel.home>
Hi,
On Mon, 3 Dec 2007, Alex Riesen wrote:
Show 36 quoted lines
> diff --git a/ident.c b/ident.c
> index 9b2a852..dbd0f52 100644
> --- a/ident.c
> +++ b/ident.c
> @@ -113,25 +113,15 @@ static int add_raw(char *buf, size_t size, int offset, const char *str)
>
> static int crud(unsigned char c)
> {
> - static char crud_array[256];
> - static int crud_array_initialized = 0;
> -
> - if (!crud_array_initialized) {
> - int k;
> -
> - for (k = 0; k <= 31; ++k) crud_array[k] = 1;
> - crud_array[' '] = 1;
> - crud_array['.'] = 1;
> - crud_array[','] = 1;
> - crud_array[':'] = 1;
> - crud_array[';'] = 1;
> - crud_array['<'] = 1;
> - crud_array['>'] = 1;
> - crud_array['"'] = 1;
> - crud_array['\''] = 1;
> - crud_array_initialized = 1;
> - }
> - return crud_array[c];
> + return c <= 32 ||
> + c == '.' ||
> + c == ',' ||
> + c == ':' ||
> + c == ';' ||
> + c == '<' ||
> + c == '>' ||
> + c == '"' ||
> + c == '\'';Or enhance ctype.c.
Ciao, Dscho