Re: [PATCH] Simplify crud() in ident.c
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Dec 3, 2007, 21:37 UTC
- Message-ID
- <20071203213702.GD17671@steel.home>
- In-Reply-To
- <Pine.LNX.4.64.0712032046480.27959@racer.site>
Johannes Schindelin, Mon, Dec 03, 2007 21:47:09 +0100:
Show 13 quoted lines
> On Mon, 3 Dec 2007, Alex Riesen wrote: > > + return c <= 32 || > > + c == '.' || > > + c == ',' || > > + c == ':' || > > + c == ';' || > > + c == '<' || > > + c == '>' || > > + c == '"' || > > + c == '\''; > > Or enhance ctype.c. >
That's be nice, but the "crud" conflicts with existing classification, so I'd have to change the is*-macros as well. Don't feel like it.
I believe the code is never in hotpath anyway so the shorter the better.