git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Simplify crud() in ident.c

From
David Kastrup <dak@gnu.org>
Date
Dec 3, 2007, 22:52 UTC
Message-ID
<85zlwre6i2.fsf@lola.goethe.zz>
In-Reply-To
<Pine.LNX.4.64.0712032247140.27959@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 26 quoted lines
> On Mon, 3 Dec 2007, Alex Riesen wrote:
>
>> Johannes Schindelin, Mon, Dec 03, 2007 21:47:09 +0100:
>> > On Mon, 3 Dec 2007, Alex Riesen wrote:
>> > > +	return  c <= 32  ||
>> > > +		c == '.' ||
>> > > +		c == ',' ||
>> > > +		c == ':' ||
>> > > +		c == ';' ||
>> > > +		c == '<' ||
>> > > +		c == '>' ||
>> > > +		c == '"' ||
>> > > +		c == '\'';
>> > 
>> > Or enhance ctype.c.
>> > 
>> 
>> That's be nice, but the "crud" conflicts with existing classification,
>> so I'd have to change the is*-macros as well. Don't feel like it.
>> 
>> I believe the code is never in hotpath anyway so the shorter the
>> better.
>
> Really?
>
> 	return !!strchr(".,:;<>\"\\", c);
What happened to c <= 32?
-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Previous: Johannes Schindelin
Message 8 of 8 in “Simplify crud() in ident.c”
  1. Simplify crud() in ident.cAlex Riesen, Dec 3, 2007
  2. Jakub NarebskiDec 3, 2007
  3. Alex RiesenDec 3, 2007
  4. Luke LuDec 3, 2007
  5. Johannes SchindelinDec 3, 2007
  6. Alex RiesenDec 3, 2007
  7. Johannes SchindelinDec 3, 2007
  8. David KastrupDec 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.