Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 6, 2007, 15:51 UTC
- Message-ID
- <Pine.LNX.4.64.0711061550580.4362@racer.site>
- In-Reply-To
- <20071106154740.GA24505@sigill.intra.peff.net>
Hi,
On Tue, 6 Nov 2007, Jeff King wrote:
Show 18 quoted lines
> On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote: > > > > > So? Why *STOP* reading the mails if just one of the directories could > > > > not be opened? IOW, I suggest: > > > > > > Because you are then trying to apply a patch series with some patches > > > potentially missing? Continuing only on errno == ENOENT seems prudent. > > > > I fail to see how the absence of one of cur/ or new/ can lead to the > > absence of patches. You could forget to save some patches, yes, but the > > presence of cur/ and new/ is no indicator for that. > > Read my message again. Alex is proposing ignoring errors in opening the > directories; I am proposing ignoring such errors _only_ when the error > is that the directory does not exist. > > IOW, if there is some other error in opening the directory, it should be > fatal, because you might be missing patches.
Yeah, sorry, I missed that.
Ciao, Dscho