git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty

From
Alex Riesen <raa.lkml@gmail.com>
Date
Nov 6, 2007, 21:50 UTC
Message-ID
<20071106215058.GA3654@steel.home>
In-Reply-To
<20071106163548.GA8207@diana.vm.bytemark.co.uk>
Karl Hasselström, Tue, Nov 06, 2007 17:35:48 +0100:
Show 25 quoted lines
> On 2007-11-06 15:51:09 +0000, Johannes Schindelin wrote:
> > On Tue, 6 Nov 2007, Jeff King wrote:
> > > On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote:
> > > > I fail to see how the absence of one of cur/ or new/ can lead to
> > > > the absence of patches. You could forget to save some patches,
> > > > yes, but the presence of cur/ and new/ is no indicator for that.
> > >
> > > Read my message again. Alex is proposing ignoring errors in
> > > opening the directories; I am proposing ignoring such errors
> > > _only_ when the error is that the directory does not exist.
> > >
> > > IOW, if there is some other error in opening the directory, it
> > > should be fatal, because you might be missing patches.
> >
> > Yeah, sorry, I missed that.
> 
> I think it might actually not be totally unreasonable to error out
> unless both directories exist. From
> http://www.qmail.org/qmail-manual-html/man5/maildir.html:
> 
>   A directory in maildir format has three subdirectories, all on the
>   same filesystem: tmp, new, and cur.
> 
> In other words, if it doesn't have these three directories, it isn't a
> Maildir directory.

On the same line of reasoning, if opening a ".../cur" fails with ENOTDIR, it must be not a Maildir...

> On the other hand, one could argue that requiring both dirs to exist
> is being too picky.

...which MUST NOT mean it does not contain useful patches. IOW, the tool can try and apply everything it finds. If user told it to get patches from the...whatever, then the patches should it get and damn qmail.

Previous: Johannes SchindelinNext: Gerrit Pape
Message 15 of 20 in “git-mailsplit: with maildirs try to process new/ if cur/ is empty”
  1. git-mailsplit: with maildirs try to process new/ if cur/ is emptyGerrit Pape, Oct 26, 2007
  2. Fernando J. PeredaOct 26, 2007
  3. git-mailsplit: with maildirs try to process new/ if cur/ is emptyGerrit Pape, Nov 5, 2007
  4. Jakub NarebskiNov 5, 2007
  5. Jeff KingNov 5, 2007
  6. Alex RiesenNov 5, 2007
  7. Michael CohenNov 6, 2007
  8. Alex RiesenNov 6, 2007
  9. Jeff KingNov 6, 2007
  10. Johannes SchindelinNov 6, 2007
  11. Jeff KingNov 6, 2007
  12. Johannes SchindelinNov 6, 2007
  13. Karl HasselströmNov 6, 2007
  14. Johannes SchindelinNov 6, 2007
  15. Alex RiesenNov 6, 2007
  16. git-mailsplit: with maildirs not only process cur/, but also new/Gerrit Pape, Nov 6, 2007
  17. Junio C HamanoNov 8, 2007
  18. Jeff KingNov 8, 2007
  19. Alex RiesenNov 8, 2007
  20. Fernando J. PeredaNov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.