git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH amend] git-mailsplit: with maildirs not only process cur/, but also new/

From
FPFernando J. Pereda <ferdy@gentoo.org>
Date
Nov 8, 2007, 07:31 UTC
Message-ID
<20071108073101.GA4875@ferdyx.org>
In-Reply-To
<7vfxzh7ajt.fsf@gitster.siamese.dyndns.org>
On Wed, Nov 07, 2007 at 06:09:26PM -0800, Junio C Hamano wrote:
Show 29 quoted lines
> Gerrit Pape <pape@smarden.org> writes:
> 
> > When saving patches to a maildir with e.g. mutt, the files are put into
> > the new/ subdirectory of the maildir, not cur/.  This makes git-am state
> > "Nothing to do.".  This patch lets git-mailsplit additional check new/
> > after reading cur/.
> >
> > This was reported by Joey Hess through
> >  http://bugs.debian.org/447396
> >
> > Signed-off-by: Gerrit Pape <pape@smarden.org>
> > ---
> >
> > On Mon, Nov 05, 2007 at 01:58:50PM +0100, Jakub Narebski wrote:
> >> > +        for (i = 0; i < 2; ++i) {
> >> Wouldn't it be better to use sizeof(sub)/sizeof(sub[0]) or it's macro
> >> equivalent ARRAY_SIZE(sub) instead of hardcoding 2 to avoid errors?
> > I made the array NULL-terminated.
> >
> > On Mon, Nov 05, 2007 at 04:26:24PM -0500, Jeff King wrote:
> >> Isn't the subject line now wrong?
> > Yes, thanks.
> >
> > On Mon, Nov 05, 2007 at 11:52:58PM +0100, Alex Riesen wrote:
> >> Why is missing "cur" (or "new", for that matter) a fatal error?
> >> Why is it error at all? How about just ignoring the fact?
> > As suggested by Jeff, I made it ignore the error on ENOENT.
> 
> Looks good to me.  Final acks please?
Fixed my concern too.
Acked-by: Fernando J. Pereda <ferdy@gentoo.org>
-- 
Fernando J. Pereda Garcimartín
20BB BDC3 761A 4781 E6ED  ED0B 0A48 5B0C 60BD 28D4
Previous: Alex Riesen
Message 20 of 20 in “git-mailsplit: with maildirs try to process new/ if cur/ is empty”
  1. git-mailsplit: with maildirs try to process new/ if cur/ is emptyGerrit Pape, Oct 26, 2007
  2. Fernando J. PeredaOct 26, 2007
  3. git-mailsplit: with maildirs try to process new/ if cur/ is emptyGerrit Pape, Nov 5, 2007
  4. Jakub NarebskiNov 5, 2007
  5. Jeff KingNov 5, 2007
  6. Alex RiesenNov 5, 2007
  7. Michael CohenNov 6, 2007
  8. Alex RiesenNov 6, 2007
  9. Jeff KingNov 6, 2007
  10. Johannes SchindelinNov 6, 2007
  11. Jeff KingNov 6, 2007
  12. Johannes SchindelinNov 6, 2007
  13. Karl HasselströmNov 6, 2007
  14. Johannes SchindelinNov 6, 2007
  15. Alex RiesenNov 6, 2007
  16. git-mailsplit: with maildirs not only process cur/, but also new/Gerrit Pape, Nov 6, 2007
  17. Junio C HamanoNov 8, 2007
  18. Jeff KingNov 8, 2007
  19. Alex RiesenNov 8, 2007
  20. Fernando J. PeredaNov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.