Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty

From: Karl Hasselström <kha@treskal.com>
Date: Nov 6, 2007, 16:35 UTC
Message-ID: <20071106163548.GA8207@diana.vm.bytemark.co.uk>
In-Reply-To: <Pine.LNX.4.64.0711061550580.4362@racer.site>

On 2007-11-06 15:51:09 +0000, Johannes Schindelin wrote:

Show 16 quoted lines

> On Tue, 6 Nov 2007, Jeff King wrote:
>
> > On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote:
> >
> > > I fail to see how the absence of one of cur/ or new/ can lead to
> > > the absence of patches. You could forget to save some patches,
> > > yes, but the presence of cur/ and new/ is no indicator for that.
> >
> > Read my message again. Alex is proposing ignoring errors in
> > opening the directories; I am proposing ignoring such errors
> > _only_ when the error is that the directory does not exist.
> >
> > IOW, if there is some other error in opening the directory, it
> > should be fatal, because you might be missing patches.
>
> Yeah, sorry, I missed that.

I think it might actually not be totally unreasonable to error out unless both directories exist. From http://www.qmail.org/qmail-manual-html/man5/maildir.html:

  A directory in maildir format has three subdirectories, all on the
  same filesystem: tmp, new, and cur.

In other words, if it doesn't have these three directories, it isn't a Maildir directory.

On the other hand, one could argue that requiring both dirs to exist is being too picky.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle