Re: [PATCH] execv_git_cmd(): also try PATH if everything else fails.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 21, 2007, 22:02 UTC
Message-ID: <Pine.LNX.4.64.0710212301490.25221@racer.site>
In-Reply-To: <20071021182150.GG16291@srparish.net>

Hi,

On Sun, 21 Oct 2007, Scott Parish wrote:

Show 12 quoted lines

> diff --git a/exec_cmd.c b/exec_cmd.c
> index 9b74ed2..374ffc9 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -99,8 +103,8 @@ int execv_git_cmd(const char **argv)
>  
>  		trace_argv_printf(argv, -1, "trace: exec:");
>  
> -		/* execve() can only ever return if it fails */
> -		execve(git_command, (char **)argv, environ);
> +		/* execvp() can only ever return if it fails */
> +		execvp(git_command, (char **)argv);

I'd rather have it conditional upon *exec_dir (see the brown paper bag patch I just sent).

Ciao, Dscho