Re: [PATCH] execv_git_cmd(): also try PATH if everything else fails.
- From
Scott Parish <srp@srparish.net>
- Date
- Oct 21, 2007, 18:21 UTC
- Message-ID
- <20071021182150.GG16291@srparish.net>
- In-Reply-To
- <Pine.LNX.4.64.0710202258440.25221@racer.site>
Earlier, we tried to find the git commands in several possible exec dirs. Now, if all of these failed, try to find the git command in PATH.
This allows you to install the git programs somewhere else than originally specified when building git, as long as you add that location to the PATH.
Implementation by Johannes Schindelin
Signed-off-by: Scott R Parish <srp@srparish.net> --- exec_cmd.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/exec_cmd.c b/exec_cmd.c index 9b74ed2..374ffc9 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -36,7 +36,8 @@ int execv_git_cmd(const char **argv) int i; const char *paths[] = { current_exec_path, getenv(EXEC_PATH_ENVIRONMENT), - builtin_exec_path }; + builtin_exec_path, + "" }; for (i = 0; i < ARRAY_SIZE(paths); ++i) { size_t len; @@ -44,9 +45,12 @@ int execv_git_cmd(const char **argv) const char *exec_dir = paths[i]; const char *tmp; - if (!exec_dir || !*exec_dir) continue; + if (!exec_dir) continue; - if (*exec_dir != '/') { + if (!*exec_dir) + /* try PATH */ + *git_command = '\0'; + else if (*exec_dir != '/') { if (!getcwd(git_command, sizeof(git_command))) { fprintf(stderr, "git: cannot determine " "current directory: %s\n", @@ -81,7 +85,7 @@ int execv_git_cmd(const char **argv) len = strlen(git_command); rc = snprintf(git_command + len, sizeof(git_command) - len, - "/git-%s", argv[0]); + "%sgit-%s", *exec_dir ? "/" : "", argv[0]); if (rc < 0 || rc >= sizeof(git_command) - len) { fprintf(stderr, "git: command name given is too long.\n"); @@ -99,8 +103,8 @@ int execv_git_cmd(const char **argv) trace_argv_printf(argv, -1, "trace: exec:"); - /* execve() can only ever return if it fails */ - execve(git_command, (char **)argv, environ); + /* execvp() can only ever return if it fails */ + execvp(git_command, (char **)argv); trace_printf("trace: exec failed: %s\n", strerror(errno));
-- 1.5.3.4.206.g58ba4-dirty