Re: [PATCH] execv_git_cmd(): also try PATH if everything else fails.

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 22, 2007, 15:36 UTC
Message-ID: <471CC380.5030603@viscovery.net>
In-Reply-To: <471CBF88.6020300@op5.se>

Andreas Ericsson schrieb:

Show 10 quoted lines

> Scott Parish wrote:
>> I'm tempted to try a different approach. What if instead of looping
>> and building up strings of all the different absolute paths we want
>> to try we just prepend to PATH with the correct extra precedence,
>> and then call execvp on the command we want?
>>
> 
> That's how the original git --exec-dir feature got implemented. There's 
> even a nifty function for it in git.c; prepend_to_path(). It's a 
> provably workable solution.

The reason that this was done is for the sake of shell scripts: They need to have the path that was finally decided as exec-path in $PATH.

But I can't think of any negative side effect if *all* exec-path candidates are in $PATH. It's important, though, that all paths are absolute because the tools chdir every now and then.

-- Hannes