Re: [PATCH] execv_git_cmd(): also try PATH if everything else fails.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 22, 2007, 04:21 UTC
Message-ID: <20071022042110.GJ14735@spearce.org>
In-Reply-To: <Pine.LNX.4.64.0710212256270.25221@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> Earlier, we tried to find the git commands in several possible exec
> dirs.  Now, if all of these failed, try to find the git command in
> PATH.

...

Show 11 quoted lines

> diff --git a/exec_cmd.c b/exec_cmd.c
> index 9b74ed2..70b84b0 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -36,7 +36,8 @@ int execv_git_cmd(const char **argv)
>  	int i;
>  	const char *paths[] = { current_exec_path,
>  				getenv(EXEC_PATH_ENVIRONMENT),
> -				builtin_exec_path };
> +				builtin_exec_path,
> +				"" };

So if the user sets GIT_EXEC_PATH="" and exports it we'll search $PATH before the builtin exec path that Git was compiled with? Are we sure we want to do that?

I'm going to throw this into pu tonight just so I don't lose it, but I have a feeling we want to amend it before merging.

-- 
Shawn.