git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 29, 2007, 19:02 UTC
Message-ID
<Pine.LNX.4.64.0707292001580.14781@racer.site>
In-Reply-To
<7vsl77m4i1.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 29 Jul 2007, Junio C Hamano wrote:
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > It is not like the reflog messages have to be very verbose; they only have 
> > to give a hint what the commit was about, and the commit name is the 
> > important information.
> 
> I've considered it, but decided against it because:
> 
>  (1) I did not like the information lossage;
> 
>  (2) this is solely to help log messages coming from outside the
>      recommended convention, and having excess will not hurt the
>      normal usage;
> 
>  (3) it is not known if messages from outside the recommended
>      convention have enough information on its first line of the
>      first paragraph; the result of s/\n.*/.../ may not be
>      sufficient "hint";
Good catch.  Didn't think of that.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 18 in “git-svn rebase screwing up commit messages”
  1. Benoit SIGOUREJul 28, 2007
  2. Junio C HamanoJul 28, 2007
  3. SeanJul 28, 2007
  4. Junio C HamanoJul 28, 2007
  5. SeanJul 28, 2007
  6. Junio C HamanoJul 28, 2007
  7. SeanJul 28, 2007
  8. Junio C HamanoJul 28, 2007
  9. Junio C HamanoJul 29, 2007
  10. 1/3 log_ref_write() -- do not chomp reflog message at the first LFJunio C Hamano, Jul 29, 2007
  11. Johannes SchindelinJul 29, 2007
  12. Junio C HamanoJul 29, 2007
  13. Johannes SchindelinJul 29, 2007
  14. 2/3 symbolic-ref, update-ref: do not refuse reflog message with LFJunio C Hamano, Jul 29, 2007
  15. 3/3 rebase: try not to munge commit log messageJunio C Hamano, Jul 29, 2007
  16. Jakub NarebskiJul 28, 2007
  17. Robin RosenbergJul 28, 2007
  18. Benoit SIGOUREJul 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.