Re: [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 29, 2007, 19:02 UTC
- Message-ID
- <Pine.LNX.4.64.0707292001580.14781@racer.site>
- In-Reply-To
- <7vsl77m4i1.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 29 Jul 2007, Junio C Hamano wrote:
Show 18 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > It is not like the reflog messages have to be very verbose; they only have > > to give a hint what the commit was about, and the commit name is the > > important information. > > I've considered it, but decided against it because: > > (1) I did not like the information lossage; > > (2) this is solely to help log messages coming from outside the > recommended convention, and having excess will not hurt the > normal usage; > > (3) it is not known if messages from outside the recommended > convention have enough information on its first line of the > first paragraph; the result of s/\n.*/.../ may not be > sufficient "hint";
Good catch. Didn't think of that.
Ciao, Dscho