[PATCH 2/3] symbolic-ref, update-ref: do not refuse reflog message with LF
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 29, 2007, 01:10 UTC
- Message-ID
- <7vps2cnhes.fsf_-_@assigned-by-dhcp.cox.net>
- In-Reply-To
- <7vzm1gnhin.fsf@assigned-by-dhcp.cox.net>
Earlier these tools refused to create a reflog entry when the message given by the calling Porcelain had a LF in it, partially to keep the file format integrity of reflog file, which is one-entry-per-line. These tools should not be dictating such a policy.
Instead, let the codepath to write out the reflog entry worry about the format integrity and allow messages with LF in them.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin-symbolic-ref.c | 2 -- builtin-update-ref.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/builtin-symbolic-ref.c b/builtin-symbolic-ref.c index d41b406..9eb95e5 100644 --- a/builtin-symbolic-ref.c +++ b/builtin-symbolic-ref.c @@ -43,8 +43,6 @@ int cmd_symbolic_ref(int argc, const char **argv, const char *prefix) msg = argv[1]; if (!*msg) die("Refusing to perform update with empty message"); - if (strchr(msg, '\n')) - die("Refusing to perform update with \\n in message"); } else if (!strcmp("--", arg)) { argc--; diff --git a/builtin-update-ref.c b/builtin-update-ref.c index feac2ed..8339cf1 100644 --- a/builtin-update-ref.c +++ b/builtin-update-ref.c @@ -23,8 +23,6 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix) msg = argv[++i]; if (!*msg) die("Refusing to perform update with empty message."); - if (strchr(msg, '\n')) - die("Refusing to perform update with \\n in message."); continue; } if (!strcmp("-d", argv[i])) {
-- 1.5.3.rc3.24.g83b3d