git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-svn rebase screwing up commit messages

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 28, 2007, 13:38 UTC
Message-ID
<7vk5skps1g.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070728092914.48f6305c.seanlkml@sympatico.ca>
Sean <seanlkml@sympatico.ca> writes:
Show 8 quoted lines
>> Having said all that, so that the readers understand the
>> background, here is a not-so-heavily-tested patch, which might
>> help.  It passes all the test suite as before, but that tells
>> how existing git-svn tests do not test many things.
>> 
>> I am not considering this for inclusion right now, by the way.
>
> FWIW your patch fixed my test case here.

Actually the patched behaviour actively encourages a bad (not in the sense that those oneline tools will not work well, but in the sense that these messages are reader unfriendly) practice; I do not think what the patch did deserves to be called "fixed".

And that is one of the reasons, other than that we are in -rc freeze that we do not add anything but unarguable fixes, that I am not considering the patch for inclusion right now.

Previous: SeanNext: Sean
Message 6 of 18 in “git-svn rebase screwing up commit messages”
  1. Benoit SIGOUREJul 28, 2007
  2. Junio C HamanoJul 28, 2007
  3. SeanJul 28, 2007
  4. Junio C HamanoJul 28, 2007
  5. SeanJul 28, 2007
  6. Junio C HamanoJul 28, 2007
  7. SeanJul 28, 2007
  8. Junio C HamanoJul 28, 2007
  9. Junio C HamanoJul 29, 2007
  10. 1/3 log_ref_write() -- do not chomp reflog message at the first LFJunio C Hamano, Jul 29, 2007
  11. Johannes SchindelinJul 29, 2007
  12. Junio C HamanoJul 29, 2007
  13. Johannes SchindelinJul 29, 2007
  14. 2/3 symbolic-ref, update-ref: do not refuse reflog message with LFJunio C Hamano, Jul 29, 2007
  15. 3/3 rebase: try not to munge commit log messageJunio C Hamano, Jul 29, 2007
  16. Jakub NarebskiJul 28, 2007
  17. Robin RosenbergJul 28, 2007
  18. Benoit SIGOUREJul 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.