Re: [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2007, 18:47 UTC
Message-ID: <7vsl77m4i1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0707291248560.14781@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> It is not like the reflog messages have to be very verbose; they only have 
> to give a hint what the commit was about, and the commit name is the 
> important information.

I've considered it, but decided against it because:

 (1) I did not like the information lossage;

 (2) this is solely to help log messages coming from outside the
     recommended convention, and having excess will not hurt the
     normal usage;

 (3) it is not known if messages from outside the recommended
     convention have enough information on its first line of the
     first paragraph; the result of s/\n.*/.../ may not be
     sufficient "hint";

 (4) log output are by default piped to "less -S" so extra
     output gives the user chance to inspect more if he chosses
     to, without hurting the end user display; and

 (5) the code was simpler and less error prone to go wrong.