Re: [PATCH] filter-branch: rewrite only refs which were not excludedbythe options

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 24, 2007, 13:46 UTC
Message-ID: <Pine.LNX.4.64.0707241445470.14781@racer.site>
In-Reply-To: <46A5FFBB.2F3B12CF@eudaptics.com>

Hi,

On Tue, 24 Jul 2007, Johannes Sixt wrote:

Show 10 quoted lines

> Johannes Schindelin wrote:
> > negatives="$(git rev-parse "$@" | while read line
> >         do
> >                 case "$line" in
> >                 $_x40) ;;
> >                 *) echo "$line";;
> >                 esac
> >         done)"
> 
> Ah, and you must move the definition of _x40 up a couple of lines.

D'oh.  Of course.

When I have more tests, and thought about the problem I hinted at in another mail, I'll send a cleaned up patch series. Promised. Rebase -i is good.

Ciao, Dscho

---

 git-filter-branch.sh |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 3fa2f63..8107a6c 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -11,6 +11,9 @@
 USAGE="git-filter-branch [-d TEMPDIR] [FILTERS] DESTBRANCH [REV-RANGE]"
 . git-sh-setup
 
+_x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
+_x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
+
 warn () {
         echo "$*" >&2
 }
@@ -322,8 +325,6 @@ done < "$tempdir"/heads
 
 # Finally update the refs
 
-_x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
-_x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
 count=0
 echo
 while read ref