Re: [PATCH] filter-branch: Big syntax change; support rewriting multiple refs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2007, 05:35 UTC
- Message-ID
- <7vfy3ejre3.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0707231829210.14781@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 6 quoted lines
> Junio, I know that this comes quite late in the game, but I really > think that the "first arg is new branch name" was a bad syntax. > > Could you please consider taking this patch (or whatever version > comes out after review ;-) or keeping filter-branch of 1.5.3? I > do not want people to get used to the borked syntax...
Yeah, "No new features after -rc" should not apply to this one.
I was actually going to ask you about it, since this is a feature we have already advertised to the public, but still is a new feature, and we'd be better off getting it right in the first public version.
> BTW I considered "git log -g --all" as an alternative to > inspecting refs/original/, but ATM this die()s if just _one_ of > the refs has no logs. Probably should fix that, too.
I do not think refs/original/ is such a hot feature. What's wrong with "gitk mine@{1}...mine"?