git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] filter-branch: rewrite only refs which were not excluded by the options

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 24, 2007, 11:06 UTC
Message-ID
<Pine.LNX.4.64.0707241205480.14781@racer.site>
In-Reply-To
<46A5C615.24C24F0F@eudaptics.com>
The rev-list options can exclude some -- or all -- refs:
	git filter-branch <some-filter> master ^master

Without this patch, these refs are assumed to be deleted, or worse, they are rewritten to some bogus merge bases.

So really exclude excluded refs from being rewritten. This also allows you to safely call

	git filter-branch <some-filter> --all <rev-list options>
to rewrite _all_ branches and tags.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	On Tue, 24 Jul 2007, Johannes Sixt wrote:
	> Johannes Schindelin wrote:
	> 
	> > +# NEEDSWORK: we should sort the unmapped refs topologically first
	> > +while read ref
	> > +do
	> > +       sha1=$(git rev-parse "$ref"^0)
	> > +       test -f "$workdir"/../map/$sha1 && continue
	> > +       # Assign the boundarie(s) in the set of rewritten commits
	> > +       # as the replacement commit(s).
	> > +       # (This would look a bit nicer if --not --stdin worked.)
	> > +       for p in $((cd "$workdir"/../map; ls | sed "s/^/^/") |
	> > +               git rev-list $ref --boundary --stdin |
	> > +               sed -n "s/^-//p")
	> > +       do
	> > +               map $p >> "$workdir"/../map/$sha1
	> > +       done
	> > +done < "$tempdir"/heads
	> 
	> This logic seems to be borked, and I don't grok it. I was trying this:
	> 
	>    git-filter-branch -- --since=2007.01.10 \
	> 		refs/heads/topic refs/heads/master
	Actually, the error lay somewhere else.  If excluded, topic should 
	not have been a rewrite candidate.
	There might be something else looming here: what to do with
		git filter-branch --subdir-filter subdir/ topic master \
			^$(git merge-base topic master)
	when topic has no changes to the subdirectory, but master has?
	I guess the safest would be to 'test -f "$workdir"/../map/$p', and 
	if at least one is not there, leave 'topic' as is.  If at least 
	one is there, however, we want to warn the user that this is not 
	possible.  (Something like: this was an unchanged ancestor: $p1, 
	but that was a changed one: $p2.  Make up your mind what you 
	want.)
 git-filter-branch.sh     |    9 ++++++++-
 t/t7003-filter-branch.sh |    9 +++++++++
 2 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 019a302..49b0f00 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -181,6 +181,7 @@ export GIT_DIR GIT_WORK_TREE=.
 
 # These refs should be updated if their heads were rewritten
 
+negatives="$(git rev-parse --revs-only "$@" | grep "^\^")"
 git rev-parse --revs-only --symbolic "$@" |
 while read ref
 do
@@ -196,7 +197,13 @@ do
 			grep "refs/\(tags\|heads\)/$ref$")"
 	esac
 
-	git check-ref-format "$ref" && echo "$ref"
+	# make sure we have a valid ref
+	git check-ref-format "$ref" || continue
+
+	# if the ref has been excluded by the other options, skip it
+	test -z "$(git rev-list -1 "$ref" $negatives)" && continue
+
+	echo "$ref"
 done > "$tempdir"/heads
 
 test -s "$tempdir"/heads ||
diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh
index c9a820d..667eda7 100755
--- a/t/t7003-filter-branch.sh
+++ b/t/t7003-filter-branch.sh
@@ -164,4 +164,13 @@ test_expect_success 'only dwim refs/heads/$ref or refs/tags/$ref' '
 	git filter-branch -f master
 '
 
+test_expect_success 'do not update uninteresting refs' '
+	branch=$(git rev-parse branch) &&
+	master=$(git rev-parse master) &&
+	git filter-branch -f --env-filter "GIT_AUTHOR_EMAIL=xy@probl.em" \
+		master ^removed-author branch &&
+	test $branch = $(git rev-parse branch) &&
+	test $master != $(git rev-parse master)
+'
+
 test_done
-- 
1.5.3.rc2.32.g35c5b-dirty
Previous: Johannes SchindelinNext: Johannes Sixt
Message 9 of 20 in “filter-branch: Big syntax change; support rewriting multiple refs”
  1. filter-branch: Big syntax change; support rewriting multiple refsJohannes Schindelin, Jul 23, 2007
  2. Junio C HamanoJul 24, 2007
  3. Johannes SchindelinJul 24, 2007
  4. Johannes SixtJul 24, 2007
  5. filter-branch: when dwim'ing a ref, only allow heads and tagsJohannes Schindelin, Jul 24, 2007
  6. Johannes SixtJul 24, 2007
  7. Johannes SchindelinJul 24, 2007
  8. filter-branch: when dwim'ing a ref, only allow heads and tagsJohannes Schindelin, Jul 24, 2007
  9. filter-branch: rewrite only refs which were not excluded by the optionsJohannes Schindelin, Jul 24, 2007
  10. Johannes SixtJul 24, 2007
  11. Johannes SchindelinJul 24, 2007
  12. Johannes SixtJul 24, 2007
  13. Johannes SchindelinJul 24, 2007
  14. Johannes SixtJul 24, 2007
  15. Johannes SchindelinJul 24, 2007
  16. Johannes SixtJul 24, 2007
  17. Johannes SchindelinJul 24, 2007
  18. filter-branch: rewrite only unexcluded refsJohannes Schindelin, Jul 24, 2007
  19. Johannes SixtJul 24, 2007
  20. Johannes SchindelinJul 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.