Re: [PATCH] filter-branch: when dwim'ing a ref, only allow heads andtags

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 24, 2007, 11:20 UTC
Message-ID: <Pine.LNX.4.64.0707241218270.14781@racer.site>
In-Reply-To: <46A5DCBC.E585A69D@eudaptics.com>

Hi,

On Tue, 24 Jul 2007, Johannes Sixt wrote:

Show 15 quoted lines

> Johannes Schindelin wrote:
> > -                       grep /"$ref")"
> > +                       grep "refs/\(tags\|heads\)/$ref$")"
> 
> Thanks, but I don't think that this is a portable grep pattern:
> 
> $ echo "abc" | grep '\(a\|x\)'
> $ echo "abc" | egrep '(a|x)'
> abc
> 
> But then, this is on some AIX 4.3. How about:
> 
>    fgrep -e "refs/heads/$ref" -e "refs/tags/$ref"
> or
>    grep -e "^refs/heads/$ref" -e "^refs/tags/$ref"

Ah yes, I remember that Junio said some time ago that "\|" is not portable.

But to be portable, let's stay with grep, and not use some fancy stuff like egrep or fgrep.

Ciao, Dscho