git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH (REVISED)] Add core.editor configuration variable

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 19, 2007, 10:00 UTC
Message-ID
<Pine.LNX.4.64.0707191058090.14781@racer.site>
In-Reply-To
<200707190848.54655.andyparkins@gmail.com>
Hi,
On Thu, 19 Jul 2007, Andy Parkins wrote:
Show 12 quoted lines
> On Thursday 2007 July 19, Adam Roben wrote:
> 
> >    Well, it turns out we already do launch an editor in other places,
> > namely "git am -i" and "git send-email --compose". So, this patch takes
> > care of those cases as well.
> 
> Perhaps I'm being overly pedantic, but it seems odd to put options that are 
> relevant only to porcelain under the "core" section.
> 
> core.pager is in the same category - but that's already in.
> 
> Would porcelain.editor be a better name for this variable?
>From my point of view you can put into "myWonderfulGit.editor".  It does 
not matter.

So why not just leave it in "core", also because -- strictly speaking -- those commands in git.git are not really your regular porcelain. They are tested with almost every commit, and therefore have a much better chance not to be broken inadvertently by changes to the core.

Ciao, Dscho

Previous: Andy ParkinsNext: Andy Parkins
Message 3 of 11 in “Add core.editor configuration variable”
  1. Add core.editor configuration variableAdam Roben, Jul 19, 2007
  2. Andy ParkinsJul 19, 2007
  3. Johannes SchindelinJul 19, 2007
  4. Andy ParkinsJul 19, 2007
  5. Johannes SchindelinJul 19, 2007
  6. Andy ParkinsJul 19, 2007
  7. Nicolas PitreJul 19, 2007
  8. Brian GernhardtJul 19, 2007
  9. Andy ParkinsJul 19, 2007
  10. Nicolas PitreJul 19, 2007
  11. Junio C HamanoJul 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.