Re: [PATCH (REVISED)] Add core.editor configuration variable

From: Andy Parkins <andyparkins@gmail.com>
Date: Jul 19, 2007, 10:48 UTC
Message-ID: <200707191148.46228.andyparkins@gmail.com>
In-Reply-To: <Pine.LNX.4.64.0707191058090.14781@racer.site>

On Thursday 2007 July 19, Johannes Schindelin wrote:

Show 17 quoted lines

> Hi,
>
> On Thu, 19 Jul 2007, Andy Parkins wrote:
> > On Thursday 2007 July 19, Adam Roben wrote:
> > >    Well, it turns out we already do launch an editor in other places,
> > > namely "git am -i" and "git send-email --compose". So, this patch takes
> > > care of those cases as well.
> >
> > Perhaps I'm being overly pedantic, but it seems odd to put options that
> > are relevant only to porcelain under the "core" section.
> >
> > core.pager is in the same category - but that's already in.
> >
> > Would porcelain.editor be a better name for this variable?
>
> From my point of view you can put into "myWonderfulGit.editor".  It does
> not matter.

By that argument, why do we bother with subsections at all. In fact why not call the variable "xhxhxjjjll.yqlaoospsp"?

They are meant to help the human remembering it.

> So why not just leave it in "core", also because -- strictly speaking --

That's what I said for pager - since it's already there. However, since the editor isn't already in, it's not a question of _leaving_ it anywhere. Better that it goes in the right place when it is first introduced.

> those commands in git.git are not really your regular porcelain. They are
> tested with almost every commit, and therefore have a much better chance

So is every other porcelain command - almost by definition, porcelain commands are the ones we use.

> not to be broken inadvertently by changes to the core.

I don't understand the point you're making here. Are you saying that we can rely on porcelain not to change or the core not to change? I'm also wondering about these "inadvertent" changes that are getting made to git core - I've not noticed them before :-)

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com