From: Johannes Schindelin Date: Thu, 19 Jul 2007 10:00:19 GMT Subject: Re: [PATCH (REVISED)] Add core.editor configuration variable Message-ID: In-Reply-To: <200707190848.54655.andyparkins@gmail.com> Hi, On Thu, 19 Jul 2007, Andy Parkins wrote: > On Thursday 2007 July 19, Adam Roben wrote: > > > Well, it turns out we already do launch an editor in other places, > > namely "git am -i" and "git send-email --compose". So, this patch takes > > care of those cases as well. > > Perhaps I'm being overly pedantic, but it seems odd to put options that are > relevant only to porcelain under the "core" section. > > core.pager is in the same category - but that's already in. > > Would porcelain.editor be a better name for this variable? >From my point of view you can put into "myWonderfulGit.editor". It does not matter. So why not just leave it in "core", also because -- strictly speaking -- those commands in git.git are not really your regular porcelain. They are tested with almost every commit, and therefore have a much better chance not to be broken inadvertently by changes to the core. Ciao, Dscho