Re: [REVISED PATCH 2/6] Introduce commit notes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 19, 2007, 09:24 UTC
Message-ID: <Pine.LNX.4.64.0707191016350.14781@racer.site>
In-Reply-To: <E4F64312-3F86-49F3-B6BD-D148AFBAB520@wincent.com>

Hi,

On Thu, 19 Jul 2007, Wincent Colaiuta wrote:

Show 15 quoted lines

> El 19/7/2007, a las 4:30, Johannes Schindelin escribi?:
> 
> > Commit notes are blobs which are shown together with the commit
> > message.  These blobs are taken from the notes ref, which you can
> > configure by the config variable core.notesRef, which in turn can
> > be overridden by the environment variable GIT_NOTES_REF.
> 
> I was trying to look back and find out what the rationale/usage scenario for
> these commit notes might be but Googling for 'git "commit notes"' doesn't
> turn up much other than the original patch you sent a few days ago.
> 
> Is this an evolution of the "git-note: A mechanisim for providing free-form
> after-the-fact annotations on commits" first introduced here?:
> 
> <http://lists.zerezo.com/git/msg465441.html>

Almost.  It is an evolution of the evolution of this.

http://thread.gmane.org/gmane.comp.version-control.git/52598/focus=52603

(which started this thread you were replying to) hints at that, but you're right, I failed to give an explicit reference:

http://article.gmane.org/gmane.comp.version-control.git/49588

Background: It was discussed how to go about storing notes (in the mail 
you cited).  I was convinced that Johan's 15-strong patch series was not 
optimal, in that it tried to introduce a _second_ object store, 
_exclusively_ for commit notes, with all kinds of problems like "how to 
fetch it?".

After thinking about how to avoid duplicating the object store, I posted my proposal, in the second link I gave.

It was shot down, because of scalability problems. They were not serious, but hurt enough that I stalled working on it, until Alberto reminded me.

Since I felt bad about shooting down Johan's patch series, and then not completing my alternative solution, I ended up working on it some more. The WIP patch 6/6 hints at what I will submit in the next days, to speed up in a transparent manner what would otherwise not scale well.

Ciao, Dscho