Re: [WIP PATCH 6/6] notes: add notes-index for a substantial speedup.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 16, 2007, 16:29 UTC
Message-ID: <Pine.LNX.4.64.0707161726430.14781@racer.site>
In-Reply-To: <20070716060117.GF32566@spearce.org>

Hi,

On Mon, 16 Jul 2007, Shawn O. Pearce wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > 
> > Actually, this commit adds two methods for a notes index:
> > 
> > - a sorted list with a fan out to help binary search, and
> > - a modified hash table.
> > 
> > It also adds a test which is used to determine the best algorithm.
> 
> I know this is a nice backwards compatible way to organize notes,
> and to make them reasonably efficiently found, but I'd almost
> rather just see them crammed into the packfile alongside of the
> commit it annotates, so that the packfile reader can quickly find
> the annotation at the same time it finds the commit.
> 
> aka packv4.
> 
> Ok, enough dreaming for today.

Yes, I also dream of having the time to play with packv4. If you read my comments in the commit-annotation thread, you'll see that I stated that packv4 would solve the problem, too.

The reason I did this series was not to push commit notes, but to make good for stalling Johan's efforts. Including a proof that the commit notes as I introduced them can be relatively cheap, too.

Ciao, Dscho