Re: [PATCH 2/6] Introduce commit notes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 15, 2007, 23:52 UTC
Message-ID: <Pine.LNX.4.64.0707160049210.14781@racer.site>
In-Reply-To: <7vlkdhck8d.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sun, 15 Jul 2007, Junio C Hamano wrote:

Show 17 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > The notes ref is a branch which contains trees much like the
> > loose object trees in .git/objects/.  In other words, to get
> > at the commit notes for a given SHA-1, take the first two
> > hex characters as directory name, and the remaining 38 hex
> > characters as base name, and look that up in the notes ref.
> > ...
> > However, a remedy is near: in a later commit, a .git/notes-index
> > will be introduced, a cached mapping from commits to commit notes,
> > to be written when the tree name of the notes ref changes.  In
> > case that notes-index cannot be written, the current (possibly
> > slow) code will come into effect again.
> 
> I wonder if it is worth using the fan-out tree structure for the
> underlying "note" trees, as the notes-index would be the primary
> way to access them.

The fan-out tree is a nice fallback solution when you cannot write the notes-index.

> Not that I've looked at the code too deeply with an intention of 
> possibly including it early.  I was hoping to see fixes to d/f code in 
> merge-recursive from either you or Alex instead ;-)

Well, yeah. I was kind of trying to cool off from my unpleasant unpack_trees() experience.

But I'll look into the issue again this week.  Promise.

Ciao, Dscho