[PATCH 0/6] Introduce commit notes
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 15, 2007, 23:19 UTC
- Message-ID
- <Pine.LNX.4.64.0707152326080.14781@racer.site>
Hi,
This patch series replaces the series I sent out a while ago, which added "commit annotations". Since "commit notes" was liked much better, here they are.
It picks up the same idea, having a pseudo-branch whose revisions contain a .git/objects/??/* like file structure, and whose blobs are the commit notes.
By default, that pseudo-branch is "refs/notes/commits", but it is overridable by the config variable core.notesRef, which in turn can be overridden by the environment variable GIT_NOTES_REF. If the given ref does not exist yet, it is interpreted as empty.
The biggest obstacle was a thinko about the scalability. Tree objects take free form name entries, and therefore a binary search by name is not possible.
Patch 6/6 is only a WIP patch, but it shows the road ahead. It adds code to generate .git/notes-index from refs/notes/commits (or any other ref you specify as notes ref), which is reused until refs/notes/commits^{tree} changes. Patch 6/6 is only meant to assess which data structure yields best performance, and how big the costs are.
However, as long as there are no public, fetchable commit notes, I think the first 5 patches are safe for application and testing.
Ciao, Dscho
Johannes Schindelin (6):
Rename git_one_line() to git_line_length() and export it
Introduce commit notes
Add git-notes
Add a test script for "git notes"
Document git-notes
notes: add notes-index for a substantial speedup..gitignore | 1 + Documentation/cmd-list.perl | 1 + Documentation/config.txt | 15 ++ Documentation/git-notes.txt | 45 ++++ Makefile | 5 +- cache.h | 1 + commit.c | 15 +- commit.h | 1 + config.c | 5 + environment.c | 1 + git-notes.sh | 61 ++++++ notes.c | 416 ++++++++++++++++++++++++++++++++++++++ notes.h | 9 + t/t3301-notes.sh | 63 ++++++ t/t3302-notes-index-expensive.sh | 118 +++++++++++ 15 files changed, 750 insertions(+), 7 deletions(-) create mode 100644 Documentation/git-notes.txt create mode 100755 git-notes.sh create mode 100644 notes.c create mode 100644 notes.h create mode 100755 t/t3301-notes.sh create mode 100755 t/t3302-notes-index-expensive.sh