Re: [PATCH v2 1/2] Add for_each_remote() function, and extend remote_find_tracking()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 10, 2007, 19:28 UTC
Message-ID: <Pine.LNX.4.64.0707102026010.4047@racer.site>
In-Reply-To: <7vtzscqf2r.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 10 Jul 2007, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > The function for_each_remote() does exactly what the name suggests.
> >
> > The function remote_find_tracking() was extended to be able to search
> > remote refs for a given local ref.  You have to set the parameter
> > "reverse" to true for that behavior.
> 
> The updated patch does not use "reverse" but the old description
> is still there.

Urgh. Right. May I ask you to paste this instead?

The function remote_find_tracking() was extended to be able to search remote refs for a given local ref. You have to set either src or dst in the refspec, and remote_find_tracking() will fill in the other and return 0.

> Daniel, one thing I fear about your "I want to store the message
> in the object store so that I can reuse even after I re-polish
> the series" desire on the cover letter topic is this kind of
> gotcha, and that is why I suggested "*** BLURB GOES HERE ***".

I am happy that my fsckup served a purpose, then. (And maybe this would be a good hint in rebase -i's man page, too, since that is how the error was introduced here.)

Ciao, Dscho