Re: [PATCH 1/2] Add for_each_remote() function, and extend remote_find_tracking()

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jul 10, 2007, 03:55 UTC
Message-ID: <Pine.LNX.4.64.0707092323160.6977@iabervon.org>
In-Reply-To: <Pine.LNX.4.64.0707100401070.4131@racer.site>

On Tue, 10 Jul 2007, Johannes Schindelin wrote:

Show 5 quoted lines

> The function for_each_remote() does exactly what the name suggests.
> 
> The function remote_find_tracking() was extended to be able to search
> remote refs for a given local ref.  You have to set the parameter
> "reverse" to true for that behavior.

I think I'd like this better if reverse meant that it looked at refspec->dst and set refspec->src, rather than returning the refspec reversed; the current version sets the refspec so that it's effectively something from the list, which makes it easier to understand.

Maybe make it so the user calls it with at most one of src and dst NULL, and it returns with neither NULL or returns -1 if it can't find anything?

	-Daniel
*This .sig left intentionally blank*