Re: [PATCH v3] Support ent:relative_path

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 5, 2007, 01:29 UTC
Message-ID: <Pine.LNX.4.64.0705050324580.4015@racer.site>
In-Reply-To: <463BD40C.6080909@gmail.com>

Hi,

On Fri, 4 May 2007, Dana How wrote:

Show 8 quoted lines

> Most commands accept relative paths,  but this is
> not true of arguments in ent:path format.  This
> patch makes all of the following git-show commands
> work in the git source tree (not just the first):
>  % cd xdiff
>  % git-show v1.5.2-rc0:xdiff/xemit.h
>  % git-show v1.5.2-rc0:./xemit.h
>  % git-show v1.5.2-rc0:../sha1_name.c

ACK.

> It also adds ent:?string as a synonym for ent:/string .
> This makes the following changes possible later:
> ent:/path is an absolute path and ent:path is relative.

NACK. The "?" thing is highly unintuitive, and I still do not think that it is worth the confusion to make Git behave funny on <tree>:<file-name>.

Think of the "todo" branch, for example. And this is not even far fetched. In many repositories I have to have separate related, but non-branch HEADs. For example, I track some projects with custom scripts. These scripts do _not_ belong into that branch. However, they are related, so I store them in the same repository.

Plus, my example of the bare-repository still has not been answered by _anyone_ in favour of changing the current behaviour.

Ciao, Dscho