Re: [PATCH v3] Support ent:relative_path

From: Shawn O. Pearce <spearce@spearce.org>
Date: May 5, 2007, 03:30 UTC
Message-ID: <20070505033039.GD16538@spearce.org>
In-Reply-To: <Pine.LNX.4.64.0705050324580.4015@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 12 quoted lines

> On Fri, 4 May 2007, Dana How wrote:
> 
> > Most commands accept relative paths,  but this is
> > not true of arguments in ent:path format.  This
> > patch makes all of the following git-show commands
> > work in the git source tree (not just the first):
> >  % cd xdiff
> >  % git-show v1.5.2-rc0:xdiff/xemit.h
> >  % git-show v1.5.2-rc0:./xemit.h
> >  % git-show v1.5.2-rc0:../sha1_name.c
> 
> ACK.

Double ACK. I'm in complete agreement with every point Dscho has made in this thread, even if I haven't quoted it. ;-)

I *really* do not want to see "<tree-ish>:<path>" to mean include the current prefix, *especially* when a bare repository is involved.

I often either do ad-hoc git-show lines against bare repositories, or have scripts that depend on this existing absolute path behavior. I'd like to see those not break. ;-)

Since "." and ".." should not be valid names in any tree of a Git repository I think we're OK to say that ":./" and ":../" are to imply relative to current prefix. But if we do ":../" then we also have to do ":../../../../../../.." ;-)

-- 
Shawn.